MWPW-157147: Dynamic Nav Status #2918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed to write tests. Pushing up a branch for feedback purposes
JasonHowellSlavin
requested review from
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309,
sonawanesnehal3 and
a team
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2918 +/- ##
==========================================
+ Coverage 96.08% 96.24% +0.16%
==========================================
Files 215 237 +22
Lines 53946 54391 +445
==========================================
+ Hits 51835 52351 +516
+ Misses 2111 2040 -71 ☔ View full report in Codecov by Sentry. |
JasonHowellSlavin
added
run-nala
|
Closing due to commits, will open another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The milo repo does not have the dynamicNavKey in the config, so the first two links will not show the feature. The second set of links, I am using the milo branch "dynamic-nav-preview" due to code bus issues, there is parity between both branches.
Resolves: MWPW-157147
Test URLs:
Bacom